Commit graph

1014 commits

Author SHA1 Message Date
kirby@puppetlabs.com
3f1a2a2dc4 Remove debug statements and fix additional config_spec tests 2020-05-07 02:00:34 -07:00
kirby@puppetlabs.com
c29ce0d56e Add remaining tests for new functionality 2020-05-07 01:57:38 -07:00
kirby@puppetlabs.com
2ed170fa23 Add tests for api additions. Begin adding tests for pool_manager additions 2020-05-06 17:45:47 -07:00
kirby@puppetlabs.com
ebde903ddc Start adding tests for ondemandvm 2020-04-30 21:02:30 -07:00
kirby@puppetlabs.com
62aaa37f78 Fix accepting request_id 2020-04-30 15:17:15 -07:00
kirby@puppetlabs.com
2b96d7e476 Fix tests for changes 2020-04-30 12:31:40 -07:00
kirby@puppetlabs.com
90e09bfe1c Replace connection_pool with vmpooler generic_connection_pool. Fix tests for changes. 2020-04-30 12:25:01 -07:00
kirby@puppetlabs.com
b32b88b753 Add parameters for redis connection pool size and timeout values. 2020-04-30 12:25:01 -07:00
kirby@puppetlabs.com
9973ed878f Implement redis connection pooling, multi, and pipelines. 2020-04-30 12:25:01 -07:00
kirby@puppetlabs.com
52bf6c4c89 First attempt at adding connection pool to pool manager 2020-04-30 12:25:01 -07:00
kirby@puppetlabs.com
70f0482d33 Provisioning on demand initially functioning prototype. 2020-04-30 12:25:01 -07:00
kirby@puppetlabs.com
edd9d9e62c Handle the delta between requested and configured limits 2020-04-30 12:25:01 -07:00
kirby@puppetlabs.com
11c5107279 Add concurrent-ruby and configure additional parts for provisioning on demand 2020-04-30 12:25:01 -07:00
kirby@puppetlabs.com
63712741a0 (POOLER-158) Getting started with provisioning on demand 2020-04-30 12:25:01 -07:00
Jenkins
e9a79cb6db (GEM) update vmpooler version to 0.11.3 2020-04-29 15:02:04 +00:00
Brandon High
9b41a542e9
Merge pull request #374 from puppetlabs/DIO-608
(DIO-608) vmpooler SUT handed out multiple times
2020-04-23 17:03:34 -07:00
Samuel Beaulieu
9c6f50691d (DIO-608) vmpooler SUT handed out multiple times
Before this change if the smove returned false, we would continue handing out the VM
which presumably could still be in the 'ready' state. Upon 'delete' that ready VM would not be
picked up and return a 404 which is consistent with the behavior seen. Adding a metric to keep
track of the smove failures since this is not expected. I think some API logging would be good
to add in the future.
2020-04-23 16:10:36 -05:00
Brandon High
48b4fb9a6b
Merge pull request #373 from jcoconnor/MAINT-Update-Codeowners
(MAINT) Update CODEOWNERS
2020-04-16 10:29:51 -07:00
John O'Connor
56a6e61dc7 (MAINT) Update CODEOWNERS
Changing ownership to DIO
2020-04-16 18:25:51 +01:00
Jenkins
4019a082f0 (GEM) update vmpooler version to 0.11.2 2020-04-16 15:54:02 +00:00
Brandon High
5fac5684a9
Merge pull request #371 from puppetlabs/POOLER-161
(POOLER-161) Fix extending vm lifetime when max lifetime is set
2020-04-15 13:27:27 -07:00
Samuel Beaulieu
953aa68907 (POOLER-161) Fix extending vm lifetime when max lifetime is set
Before this PR, the current running time was being inspected to decide if the
vm lifetime could be extended. But since vm lifetime is absolute and not relative
this check is now removed.
2020-04-15 13:17:14 -05:00
Brandon High
9ab1b89a6c
Merge pull request #370 from mattkirby/purge_failed
(POOLER-165) Fix purge_unconfigured_folders
2020-04-07 11:27:36 -07:00
kirby@puppetlabs.com
fc616ce055 Fix rubocop offenses 2020-04-07 11:22:05 -07:00
kirby@puppetlabs.com
68ecb7a3a4 (POOLER-165) Fix purge_unconfigured_folders
This commit fixes the purge_unconfigured_folders feature to ensure that it can successfully identify folders and instances that are no longer used. Without this change the feature does not work as advertised.
2020-04-07 09:39:59 -07:00
Brandon High
04a3c448fd
Merge pull request #369 from puppetlabs/16c0dependabot/bundler/rake-gte-12.3-and-lt-14.0
Update rake requirement from ~> 12.3 to >= 12.3, < 14.0
2020-03-18 14:25:13 -07:00
Jenkins
451003484e (GEM) update vmpooler version to 0.11.1 2020-03-17 23:51:30 +00:00
Brandon High
458b862b63
Update CHANGELOG for 0.11.1 2020-03-17 16:45:08 -07:00
Brandon High
0c0ee0cdd2
rake gemspec dep in ~> format instead of range 2020-03-17 15:10:15 -07:00
dependabot-preview[bot]
526d88d673
Update rake requirement from ~> 12.3 to >= 12.3, < 14.0
Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](https://github.com/ruby/rake/compare/v12.3.0...v13.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-17 19:33:09 +00:00
Brandon High
3e2ab2db5f
Merge pull request #367 from puppetlabs/dependabot
Add Dependabot to keep gems updated
2020-03-17 12:32:01 -07:00
Brandon High
0289dac4f0
Merge pull request #366 from mattkirby/update_gems
Update gem dependencies to latest versions
2020-03-17 12:31:08 -07:00
Brandon High
5cfad48aac
Merge pull request #368 from mattkirby/docker_compose_defaults
Remove providers addition to docker-compose.yml
2020-03-17 12:30:30 -07:00
kirby@puppetlabs.com
85cd1fb4ed Remove providers addition to docker-compose.yml 2020-03-17 12:17:53 -07:00
Brandon High
ad39b53445
Merge pull request #365 from mattkirby/pooler_156
(POOLER-156) Detect redis connection failures
2020-03-17 12:07:26 -07:00
a717e5c5ca
Add Dependabot to keep gems updated 2020-03-17 15:01:57 -04:00
kirby@puppetlabs.com
7597185fa4 Fix reference to unused e to satisfy rubocop 2020-03-17 11:24:03 -07:00
kirby@puppetlabs.com
9e5b434582 Update gem dependencies to latest versions
This commit updates vmpooler gem dependencies in Gemfile and gemspec files. Without this change vmpooler is pinned to out of date version of multiple libraries.
2020-03-17 11:20:57 -07:00
kirby@puppetlabs.com
283dea62a7 (POOLER-156) Detect redis connection failures
This commit adds detection for redis connection failures to pool_manager. When a connection fails the error will be raised to executeforcing the connection to be re-established. Without this change, when a redis connection fails, it generates a redis connection error, which is swallowed by a rescue for StandardError, preventing the manager application component from recovering in the case of a redis connection failure.
2020-03-17 11:17:52 -07:00
Brandon High
4cfa8732fb
Merge pull request #363 from mattkirby/dockerignore
Add a .dockerignore file
2020-03-12 16:22:12 -07:00
kirby@puppetlabs.com
329c24676e Add a .dockerignore file 2020-03-12 14:36:21 -07:00
Jenkins
d653ce482e (GEM) update vmpooler version to 0.11.0 2020-03-11 22:39:14 +00:00
Brandon High
c1198d8e59
Update CHANGELOG for 0.11.0
I will remember not to tag or bump version.rb because the pipeline
handles that.
2020-03-11 15:35:38 -07:00
mattkirby
339f1db045
Merge pull request #361 from highb/2020-03-05_update_rubocop_exceptions
Manual Rubocop Fixes
2020-03-10 13:44:48 -07:00
mattkirby
66029c7c13
Merge pull request #362 from highb/pin_docker_to_jruby_9_2_9
Pin to JRuby 9.2.9 in Dockerfiles
2020-03-09 12:43:57 -07:00
Brandon High
e7f53d659a
Pin to JRuby 9.2.9 in Dockerfiles
This commit pins all the `Dockerfile` to Jruby 9.2.9. This is an
attempt to narrow down if the JRuby 9.2.11 is the reason for the
StackOverflow we were seeing or if there is something strange going on
with an update to the Gemfiles.
2020-03-09 11:58:38 -07:00
Brandon High
d20e2a89b5
Require rubocop checks in Travis
This commit updates Travis to require Rubocop to pass. This is possible
now due to the fixes in #361.
2020-03-05 17:28:33 -08:00
Brandon High
57d2010db0
Use break instead of return in migrate_vm connection pool
This commit switches the early `return` in `migrate_vm`'s connection
pooling block to a `break`, since `return` implies you are returning
something from a method and I don't think `migrate_vm` wants to do that.

This is a place where a partial type system like Sorbet seems useful
because then we'd have some idea about what the intended return is here.
2020-03-05 17:17:30 -08:00
Brandon High
392232fb6a
Remove duplicated return statements
This commit removes two duplicate return statements in both branches of
a conditional with one return statement outside the conditional blocks.
2020-03-05 17:13:51 -08:00
Brandon High
ed88fb1302
Remove shadowed variable from get_provider_for_pool
This commit updates a block that was creating a shadow variable to use a
different variable.
2020-03-05 17:12:09 -08:00