(maint) Update Rubobop Todo for 16th March

Quite a few rubocop violations have been resolved.  This commit updates the
rubocop todo file to reflect this.
This commit is contained in:
Glenn Sarti 2017-03-16 15:43:18 -07:00
parent 885d8d2b1c
commit 04c91588af

View file

@ -1,6 +1,6 @@
# This configuration was generated by # This configuration was generated by
# `rubocop --auto-gen-config` # `rubocop --auto-gen-config`
# on 2017-03-02 20:16:29 -0800 using RuboCop version 0.47.1. # on 2017-03-16 15:37:18 -0700 using RuboCop version 0.47.1.
# The point is for the user to remove these configuration records # The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base. # one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new # Note that changes in the inspected code, or installation of new
@ -13,10 +13,9 @@ Lint/AssignmentInCondition:
- 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/helpers.rb'
- 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/api/v1.rb'
# Offense count: 6 # Offense count: 5
Lint/ConditionPosition: Lint/ConditionPosition:
Exclude: Exclude:
- 'lib/vmpooler/api/dashboard.rb'
- 'lib/vmpooler/pool_manager.rb' - 'lib/vmpooler/pool_manager.rb'
# Offense count: 3 # Offense count: 3
@ -30,13 +29,12 @@ Lint/ShadowingOuterLocalVariable:
Exclude: Exclude:
- 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/helpers.rb'
# Offense count: 8 # Offense count: 3
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument: Lint/UnusedMethodArgument:
Exclude: Exclude:
- 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/helpers.rb'
- 'lib/vmpooler/dummy_statsd.rb'
- 'lib/vmpooler/pool_manager.rb' - 'lib/vmpooler/pool_manager.rb'
- 'lib/vmpooler/vsphere_helper.rb' - 'lib/vmpooler/vsphere_helper.rb'
@ -46,11 +44,6 @@ Lint/UselessAssignment:
- 'lib/vmpooler/api/dashboard.rb' - 'lib/vmpooler/api/dashboard.rb'
- 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/helpers.rb'
# Offense count: 5
# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 5
# Offense count: 1 # Offense count: 1
# Configuration parameters: CountKeywordArgs. # Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists: Metrics/ParameterLists:
@ -134,13 +127,12 @@ Style/EmptyLines:
Exclude: Exclude:
- 'lib/vmpooler/api/dashboard.rb' - 'lib/vmpooler/api/dashboard.rb'
# Offense count: 2 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles. # Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
Style/EmptyLinesAroundClassBody: Style/EmptyLinesAroundClassBody:
Exclude: Exclude:
- 'lib/vmpooler/api/dashboard.rb'
- 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/helpers.rb'
# Offense count: 3 # Offense count: 3
@ -151,27 +143,12 @@ Style/EmptyLinesAroundModuleBody:
Exclude: Exclude:
- 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/helpers.rb'
# Offense count: 2
# Cop supports --auto-correct.
Style/EmptyLiteral:
Exclude:
- 'lib/vmpooler/api/dashboard.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Exclude:
- 'lib/vmpooler/dummy_statsd.rb'
# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing: Style/ExtraSpacing:
Exclude: Exclude:
- 'lib/vmpooler/pool_manager.rb' - 'lib/vmpooler/pool_manager.rb'
- 'lib/vmpooler/statsd.rb'
# Offense count: 2 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct.
@ -244,13 +221,11 @@ Style/IndentHash:
- 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/helpers.rb'
- 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/api/v1.rb'
# Offense count: 4 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Width. # Configuration parameters: Width.
Style/IndentationWidth: Style/IndentationWidth:
Exclude: Exclude:
- 'lib/vmpooler/api/dashboard.rb'
- 'lib/vmpooler/api/reroute.rb'
- 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/api/v1.rb'
- 'lib/vmpooler/vsphere_helper.rb' - 'lib/vmpooler/vsphere_helper.rb'
@ -412,13 +387,12 @@ Style/SpaceAroundKeyword:
Exclude: Exclude:
- 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/api/v1.rb'
# Offense count: 4 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment. # Configuration parameters: AllowForAlignment.
Style/SpaceAroundOperators: Style/SpaceAroundOperators:
Exclude: Exclude:
- 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/api/v1.rb'
- 'lib/vmpooler/statsd.rb'
# Offense count: 4 # Offense count: 4
# Cop supports --auto-correct. # Cop supports --auto-correct.
@ -442,25 +416,14 @@ Style/SpaceInsideParens:
Exclude: Exclude:
- 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/api/v1.rb'
# Offense count: 2 # Offense count: 12
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
Exclude:
- 'lib/vmpooler/api.rb'
# Offense count: 47
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
Style/StringLiterals: Style/StringLiterals:
Exclude: Exclude:
- 'lib/vmpooler/api.rb'
- 'lib/vmpooler/api/dashboard.rb'
- 'lib/vmpooler/api/reroute.rb'
- 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/api/v1.rb'
- 'lib/vmpooler/graphite.rb'
- 'lib/vmpooler/pool_manager.rb' - 'lib/vmpooler/pool_manager.rb'
- 'lib/vmpooler/statsd.rb'
- 'lib/vmpooler/vsphere_helper.rb' - 'lib/vmpooler/vsphere_helper.rb'
- 'vmpooler' - 'vmpooler'