From 04c91588aff3d488419e6d663a72b1695a74ad00 Mon Sep 17 00:00:00 2001 From: Glenn Sarti Date: Thu, 16 Mar 2017 15:43:18 -0700 Subject: [PATCH] (maint) Update Rubobop Todo for 16th March Quite a few rubocop violations have been resolved. This commit updates the rubocop todo file to reflect this. --- .rubocop_todo.yml | 51 +++++++---------------------------------------- 1 file changed, 7 insertions(+), 44 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1d17df2..027cd7f 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2017-03-02 20:16:29 -0800 using RuboCop version 0.47.1. +# on 2017-03-16 15:37:18 -0700 using RuboCop version 0.47.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -13,10 +13,9 @@ Lint/AssignmentInCondition: - 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/v1.rb' -# Offense count: 6 +# Offense count: 5 Lint/ConditionPosition: Exclude: - - 'lib/vmpooler/api/dashboard.rb' - 'lib/vmpooler/pool_manager.rb' # Offense count: 3 @@ -30,13 +29,12 @@ Lint/ShadowingOuterLocalVariable: Exclude: - 'lib/vmpooler/api/helpers.rb' -# Offense count: 8 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. Lint/UnusedMethodArgument: Exclude: - 'lib/vmpooler/api/helpers.rb' - - 'lib/vmpooler/dummy_statsd.rb' - 'lib/vmpooler/pool_manager.rb' - 'lib/vmpooler/vsphere_helper.rb' @@ -46,11 +44,6 @@ Lint/UselessAssignment: - 'lib/vmpooler/api/dashboard.rb' - 'lib/vmpooler/api/helpers.rb' -# Offense count: 5 -# Configuration parameters: CountBlocks. -Metrics/BlockNesting: - Max: 5 - # Offense count: 1 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: @@ -134,13 +127,12 @@ Style/EmptyLines: Exclude: - 'lib/vmpooler/api/dashboard.rb' -# Offense count: 2 +# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines Style/EmptyLinesAroundClassBody: Exclude: - - 'lib/vmpooler/api/dashboard.rb' - 'lib/vmpooler/api/helpers.rb' # Offense count: 3 @@ -151,27 +143,12 @@ Style/EmptyLinesAroundModuleBody: Exclude: - 'lib/vmpooler/api/helpers.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Style/EmptyLiteral: - Exclude: - - 'lib/vmpooler/api/dashboard.rb' - # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: compact, expanded -Style/EmptyMethod: - Exclude: - - 'lib/vmpooler/dummy_statsd.rb' - -# Offense count: 3 -# Cop supports --auto-correct. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. Style/ExtraSpacing: Exclude: - 'lib/vmpooler/pool_manager.rb' - - 'lib/vmpooler/statsd.rb' # Offense count: 2 # Cop supports --auto-correct. @@ -244,13 +221,11 @@ Style/IndentHash: - 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/v1.rb' -# Offense count: 4 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: Width. Style/IndentationWidth: Exclude: - - 'lib/vmpooler/api/dashboard.rb' - - 'lib/vmpooler/api/reroute.rb' - 'lib/vmpooler/api/v1.rb' - 'lib/vmpooler/vsphere_helper.rb' @@ -412,13 +387,12 @@ Style/SpaceAroundKeyword: Exclude: - 'lib/vmpooler/api/v1.rb' -# Offense count: 4 +# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment. Style/SpaceAroundOperators: Exclude: - 'lib/vmpooler/api/v1.rb' - - 'lib/vmpooler/statsd.rb' # Offense count: 4 # Cop supports --auto-correct. @@ -442,25 +416,14 @@ Style/SpaceInsideParens: Exclude: - 'lib/vmpooler/api/v1.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpaceInsidePercentLiteralDelimiters: - Exclude: - - 'lib/vmpooler/api.rb' - -# Offense count: 47 +# Offense count: 12 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Exclude: - - 'lib/vmpooler/api.rb' - - 'lib/vmpooler/api/dashboard.rb' - - 'lib/vmpooler/api/reroute.rb' - 'lib/vmpooler/api/v1.rb' - - 'lib/vmpooler/graphite.rb' - 'lib/vmpooler/pool_manager.rb' - - 'lib/vmpooler/statsd.rb' - 'lib/vmpooler/vsphere_helper.rb' - 'vmpooler'