mirror of
https://github.com/puppetlabs/vmpooler.git
synced 2026-01-26 10:08:40 -05:00
ab92eb366d
Screen out redundant begin block rubocop compliance checks as these are causing vsphere.rb and pool_manager.rb to fail with differing ruby version checks.
100 lines
2.1 KiB
YAML
100 lines
2.1 KiB
YAML
inherit_from: .rubocop_todo.yml
|
|
|
|
AllCops:
|
|
Include:
|
|
- 'lib/**/*.rb'
|
|
- 'vmpooler'
|
|
Exclude:
|
|
- 'lib/public/lib/**/*'
|
|
- 'scripts/**/*'
|
|
- 'spec/**/*'
|
|
- 'vendor/**/*'
|
|
- Gemfile
|
|
- Rakefile
|
|
- Vagrantfile
|
|
|
|
Style/Documentation:
|
|
Enabled: false
|
|
|
|
# Line length is not useful
|
|
Layout/LineLength:
|
|
Enabled: false
|
|
|
|
# Empty method definitions over more than one line is ok
|
|
Style/EmptyMethod:
|
|
Enabled: false
|
|
|
|
# Due to legacy codebase
|
|
# - Globals are used liberally
|
|
Style/GlobalVars:
|
|
Enabled: false
|
|
# - A lot of complexity
|
|
Metrics/AbcSize:
|
|
Enabled: false
|
|
Metrics/PerceivedComplexity:
|
|
Enabled: false
|
|
Metrics/CyclomaticComplexity:
|
|
Enabled: false
|
|
Metrics/BlockNesting:
|
|
Enabled: false
|
|
# - Long Methods, Classes, Blocks, and Modules
|
|
Metrics/MethodLength:
|
|
Enabled: false
|
|
Metrics/ClassLength:
|
|
Enabled: false
|
|
Metrics/BlockLength:
|
|
Enabled: false
|
|
Metrics/ModuleLength:
|
|
Enabled: false
|
|
|
|
# WordArray is crashing rubocop in lib/vmpooler/api/helpers.rb
|
|
Style/WordArray:
|
|
Enabled: false
|
|
|
|
# RedundantBegin is causing lib/pool_manager & vsphere.rb to fail in Ruby 2.5+
|
|
Style/RedundantBegin:
|
|
Enabled: false
|
|
|
|
# Either sytnax for regex is ok
|
|
Style/RegexpLiteral:
|
|
Enabled: false
|
|
|
|
# In some cases readability is better without these cops enabled
|
|
Style/ConditionalAssignment:
|
|
Enabled: false
|
|
Style/Next:
|
|
Enabled: false
|
|
Metrics/ParameterLists:
|
|
Max: 10
|
|
Style/GuardClause:
|
|
Enabled: false
|
|
|
|
# Enforce LF line endings, even when on Windows
|
|
Layout/EndOfLine:
|
|
EnforcedStyle: lf
|
|
|
|
# Added in 0.80, don't really care about the change
|
|
Style/HashEachMethods:
|
|
Enabled: false
|
|
|
|
# Added in 0.80, don't really care about the change
|
|
Style/HashTransformKeys:
|
|
Enabled: false
|
|
|
|
# Added in 0.80, don't really care about the change
|
|
Style/HashTransformValues:
|
|
Enabled: false
|
|
|
|
# These short variable names make sense as exceptions to the rule, but generally I think short variable names do hurt readability
|
|
Naming/MethodParameterName:
|
|
AllowedNames:
|
|
- vm
|
|
- dc
|
|
- s
|
|
- x
|
|
- f
|
|
|
|
# Standard comparisons seem more readable
|
|
Style/NumericPredicate:
|
|
Enabled: true
|
|
EnforcedStyle: comparison
|