Commit graph

7 commits

Author SHA1 Message Date
Glenn Sarti
5e0aefc629 (maint) Fix minor rubocop violations
Fix minor rubocop violations
2017-07-12 17:13:21 -07:00
Glenn Sarti
ba686e3c0a (maint) Update VMPooler files with fixes for Rubocop violations
This commit updates vmpooler.rb, api.rb and providers.rb with style changes as
per rubocop style violations.

This commit also updates the rubocop configuration to always use LF line endings
even on Windows as rubocop was expecting CRLF even though git is configured
for LF.
2017-05-17 13:52:28 -07:00
Glenn Sarti
d94b5e6896 (maint) Update rubocop.yml to ignore 2 cops
This commit updates the rubocop_todo.yml file for all of the new code that has
been introduced.

This commit adds two cops to the ignore list
- Style/ConditionalAssignment
- Next

In some cases the readability of code is better even when the cops are raised.
This commit disables the cops so they will not be flagged as violations
2017-04-03 11:30:02 -07:00
Glenn Sarti
a276542098 (maint) Ignore the crashing WordArray cop in rubocop
Previously the Style/WordArray cop was crashing in the following fil:
lib/vmpooler/api/helpers.rb

This commit disables this cop until the root cause can be determined.
2017-03-16 16:00:32 -07:00
Glenn Sarti
885d8d2b1c (maint) Add additional rubocop exceptions
This commit adds the following exceptions:

- Style/EmptyMethod
  Methods which are empty are typically supposed to not spread over two lines
  however this is a matter of readability and should not be considered a
  violation
- Metrics/BlockNesting
  Due to a legacy codebase there are instances where the block depth is quite
  high.  Ignore these violations for the time being.
2017-03-16 15:41:02 -07:00
Glenn Sarti
c14403682a (maint) Fix rubocop offenses
This commit updates VM Pooler to fix any existing rubocop offenses and also
fixes any offenses in the lib/vmpooler.rb file.  This commit also regenerates
the Todo file.
2017-03-07 20:17:32 -08:00
Glenn Sarti
85a2fa4f20 (maint) Add rubocop for testing
This commit adds the rubocop gem, a rubocop rake task and an initial rubocop
configuration file in prepartion for using rubocop in CI.

This commit also adds a rubocop todo file that exempts existing files from
violations.
2017-02-10 13:33:36 -08:00