Commit graph

556 commits

Author SHA1 Message Date
Scott Schneider
10db0c4c6a Catch improperly-formatted data payloads 2015-03-20 13:03:29 -07:00
Scott Schneider
d48d487de0 Validate data payload before operating on it 2015-03-20 12:52:17 -07:00
Scott Schneider
7b97e58e0f Clean up Redis VM objects after redis['data_ttl'] 2015-03-20 10:25:51 -07:00
Scott Schneider
48a9ef0dfd Store checkout and destroy timestamps 2015-03-20 09:57:47 -07:00
Scott Schneider
99a18c781a Adding VM-tagging support via PUT /vm/:hostname endpoint 2015-03-19 11:27:39 -07:00
Scott Schneider
558c70ab0d Use $redis.hgetall rather than hget in a loop
This cuts down on render-time for the /api/v1/summary endpoint drastically.
2015-03-09 11:12:39 -07:00
Scott Schneider
d1e4acbd55 /summary per-pool metrics
This commit also consolidates the 'get_boot_metrics' and
'get_clone_metrics' methods into a single parameterized
'get_task_metrics' method.
2015-03-06 14:40:39 -08:00
Scott Schneider
e83b3e47af (maint) fix typo 2015-03-04 20:03:16 -08:00
Colin
89ee786908 Merge pull request #64 from sschneid/boot_metrics
Show boot metrics in /status and /summary endpoints
2015-03-04 16:09:45 -08:00
Scott Schneider
c86f680a41 Show boot metrics in /status and /summary endpoints 2015-03-04 16:06:42 -08:00
Colin
1fa2da575a Merge pull request #61 from sschneid/more_granular_metrics
More granular metrics
2015-03-04 16:02:38 -08:00
Scott Schneider
18703efd60 Guard against nil VM clone time 2015-03-04 13:06:49 -08:00
Scott Schneider
7f8d4111ef (maint) Fixing spacing 2015-03-04 11:36:37 -08:00
Scott Schneider
e347e2b6b4 Don't include daily_clone durations in average if nothing was cloned 2015-03-04 11:28:31 -08:00
Scott Schneider
35e78aacb5 Use 'date_str' instead of 'date' 2015-03-04 11:12:23 -08:00
Scott Schneider
5453ec6206 Use new helper methods in /summary route 2015-03-04 10:28:19 -08:00
Scott Schneider
201897214b Move clone metric-gathering to 'get_clone_metrics' helper 2015-03-04 09:58:11 -08:00
Scott Schneider
1397ff93c1 Move capacity metric-gathering to 'get_capacity_metrics' helper 2015-03-04 09:49:16 -08:00
Scott Schneider
fd0e5cb438 Move queue metric-gathering to 'get_queue_metrics' helper 2015-03-04 09:41:10 -08:00
Scott Schneider
0c3f84e072 Slight rework of data param validation 2015-03-04 09:31:56 -08:00
Scott Schneider
c1099a8273 Add 'get_clone_times' helper 2015-03-04 09:21:06 -08:00
Scott Schneider
4f880497b7 Alphabetize existing helpers 2015-03-04 09:15:04 -08:00
Scott Schneider
ba01b60541 Store template (pool) name with hostname in Redis metric keys 2015-03-03 15:21:06 -08:00
Scott Schneider
a2a8515728 Track 'boot' (pending -> ready) durations 2015-03-03 15:16:17 -08:00
Scott Schneider
6d6dbfa2c8 Initial 2015-02-26 15:13:24 -08:00
Colin
b965ce3a55 Merge pull request #59 from sschneid/maint
Set HTTP status codes, a bit of code standardization
2015-02-26 09:54:47 -08:00
Scott Schneider
0a9d4e4a3f Don't return 503 for a valid GET /status request 2015-02-26 09:51:14 -08:00
Scott Schneider
a8ecd59014 Merge pull request #58 from colinPL/json_gen_error
(maint) Fix Divide by 0 Bug
2015-02-25 17:47:22 -08:00
Scott Schneider
bfbcde24be set proper HTTP status codes 2015-02-25 17:46:31 -08:00
Scott Schneider
c66315ce26 deprecate 'Hash.new' for '{}' 2015-02-25 17:46:29 -08:00
Scott Schneider
2fa7e1e736 move 'content_type :json' to the beginning of endpoint defs 2015-02-25 17:24:28 -08:00
Colin
67ee061776 (maint) Fix Divide by 0 Bug
When a redis key does not exist for a single-day summary, the
total_clones_per_day array has a length of 1 with a single value of 0.
This gets past an initial check of array length, but is then reduced to
a value of 0, which is then used as the denominator of an average
calculation. The result of this calculation is NaN and later causes
JSON.pretty_generate to raise an exception.

This also includes a check on the min_max_clone_times array, because
[].minmax returns [nil, nil].
2015-02-25 15:52:26 -08:00
Colin
251ae36aa7 Merge pull request #56 from sschneid/summary_default_from
Use today as a default 'from' value
2015-02-25 15:51:21 -08:00
Scott Schneider
e121adb76b Set Sinatra not_found to JSON ok: false 2015-02-25 15:02:29 -08:00
Scott Schneider
7d013a4c2f Use today as a default 'from' value 2015-02-25 14:49:29 -08:00
Scott Schneider
3595453738 Avoid possible divide-by-zero or nil values 2015-02-25 09:12:45 -08:00
Scott Schneider
a4a91a2df9 Predefine capacity:percent and queue:total 2015-02-24 15:51:33 -08:00
Scott Schneider
3d8985fd59 Explicitly set Redis values as integers 2015-02-24 15:36:08 -08:00
Scott Schneider
c29f6e7c66 (Re)structured /status API endpoint 2015-02-24 15:26:29 -08:00
Scott Schneider
d262cb9c95 Merge pull request #53 from colinPL/add_stddev_summary
(QENG-1873) Match status endpoint
2015-02-24 10:00:17 -08:00
Colin
90d6ac2f1b (QENG-1873) Fix Average Duration Calculation
Use the mean helper function to calculate average clone duration.
2015-02-24 09:32:22 -08:00
Colin
85ac329894 (QENG-1873) Fix /0 Error
Calculate total count before trying to use it in average calculation.
2015-02-24 09:26:50 -08:00
Colin
5db5df826f (QENG-1873) Add count Section to summary Result
This adds a :count key to both the overall and daily results. The
payload is now divided in to :duration and :count values for summary
data. The daily results do not include anything under :count except the
total number of VMs cloned for the day. The overall :count includes
total, including minimum, maximum, and average VMs cloned for the date
range requested.
2015-02-24 09:23:58 -08:00
Colin
57520ae995 (QENG-1873) Fix Key Name Issue And minmax
This commit fixes the problem of lingering :timings that were renamed
to :duration. This should resolve a NilClass failure. This also converts
string results from redis to float so that future minmax calls will
treat them as numerics instead of strings.
2015-02-24 08:52:33 -08:00
Colin
ef333ca65f (QENG-1873) Match status endpoint
These changes are to match the status endpoints JSON payload. This also
introduces both clone timings and information on total clones. The field
"day" is renamed to "date" to accomodate when from/to will include
times.
2015-02-23 17:36:50 -08:00
Scott Schneider
97fe235561 Round capacity percentage to 1 decimal place 2015-02-20 14:06:52 -08:00
Scott Schneider
3c22f55793 Predefine entire 'result' hash rather than a-key-at-a-time 2015-02-20 13:23:54 -08:00
Scott Schneider
0253008a3f Extend dashboard stats
This PR includes the following changes:

  - everything at the /dashboard/stats/vmpooler/numbers API endpoint has
  been moved to /status, and stats-vmpooler-numbers.js is now looking to
  /status for it's metrics

  - added '.extra'-classed metrics to stats-vmpooler-numbers.js to pull
  in daily clone totals, average clone time, etc.

  - dashboard.css includes an @media query to display the extra metrics
  if the dashboard's max-width exceeds 1500px
2015-02-20 11:23:48 -08:00
Colin
8a7a327331 Add /summary endpoint
Add an endpoint that returns clone totals and average clone time for
the given time spans. The time spans are determined by the query
parameters "from" and "to", with the resulting range being inclusive of
both. If you want a single day, it should be both the "from" and the
"to" value.
2015-02-20 10:10:18 -08:00
Scott Schneider
525b87d74a Fixing typo in 'percent' 2015-02-17 08:41:19 -08:00