Screen out redundant begin block rubocop compliance checks as these
are causing vsphere.rb and pool_manager.rb to fail with differing
ruby version checks.
This commit:
* explicitly defines some short variable names that
generally make sense in the codebase.
* set numeric comparisons to be enforced instead of the predicate style
Previously, there were some rubocop rule names that were causing rubocop
to fail to run entirely.
This commit updates the rubocop configs to match the new rubocop rule
names so that we can see all the issues that need correcting.
This commit fixes the many rubocop offenses. Also modifies the rubocop
settings:
- Set max method params higher than the default of 5
- Ignore Style/GuardClause. In some cases it's eaiser to read without the guard
- Renamed a cop
This commit updates vmpooler.rb, api.rb and providers.rb with style changes as
per rubocop style violations.
This commit also updates the rubocop configuration to always use LF line endings
even on Windows as rubocop was expecting CRLF even though git is configured
for LF.
This commit updates the rubocop_todo.yml file for all of the new code that has
been introduced.
This commit adds two cops to the ignore list
- Style/ConditionalAssignment
- Next
In some cases the readability of code is better even when the cops are raised.
This commit disables the cops so they will not be flagged as violations
Previously the Style/WordArray cop was crashing in the following fil:
lib/vmpooler/api/helpers.rb
This commit disables this cop until the root cause can be determined.
This commit adds the following exceptions:
- Style/EmptyMethod
Methods which are empty are typically supposed to not spread over two lines
however this is a matter of readability and should not be considered a
violation
- Metrics/BlockNesting
Due to a legacy codebase there are instances where the block depth is quite
high. Ignore these violations for the time being.
This commit updates VM Pooler to fix any existing rubocop offenses and also
fixes any offenses in the lib/vmpooler.rb file. This commit also regenerates
the Todo file.
This commit adds the rubocop gem, a rubocop rake task and an initial rubocop
configuration file in prepartion for using rubocop in CI.
This commit also adds a rubocop todo file that exempts existing files from
violations.
