From fb323a70bfc248734077bcaa88824bca512b3e54 Mon Sep 17 00:00:00 2001 From: Rick Bradley Date: Tue, 12 Jul 2016 16:50:50 -0500 Subject: [PATCH] [QENG-4075] Factor out Vmpooler::DummyStatsd This makes it visible to lib/vmpooler.rb, as well as putting this dummy metrics endpoint in its own file for easier discovery. --- lib/vmpooler.rb | 2 +- lib/vmpooler/dummy_statsd.rb | 20 ++++++++++++++++++++ lib/vmpooler/statsd.rb | 19 ------------------- 3 files changed, 21 insertions(+), 20 deletions(-) create mode 100644 lib/vmpooler/dummy_statsd.rb diff --git a/lib/vmpooler.rb b/lib/vmpooler.rb index 3ea3412..0e5707c 100644 --- a/lib/vmpooler.rb +++ b/lib/vmpooler.rb @@ -12,7 +12,7 @@ module Vmpooler require 'yaml' require 'set' - %w( api graphite logger pool_manager vsphere_helper ).each do |lib| + %w( api graphite logger pool_manager vsphere_helper statsd dummy_statsd ).each do |lib| begin require "vmpooler/#{lib}" rescue LoadError diff --git a/lib/vmpooler/dummy_statsd.rb b/lib/vmpooler/dummy_statsd.rb new file mode 100644 index 0000000..2b1b621 --- /dev/null +++ b/lib/vmpooler/dummy_statsd.rb @@ -0,0 +1,20 @@ +module Vmpooler + class DummyStatsd + attr_reader :server, :port, :prefix + + def initialize(params = {}) + end + + def increment(label) + true + end + + def gauge(label, value) + true + end + + def timing(label, duration) + true + end + end +end diff --git a/lib/vmpooler/statsd.rb b/lib/vmpooler/statsd.rb index 2bca00a..60d8b21 100644 --- a/lib/vmpooler/statsd.rb +++ b/lib/vmpooler/statsd.rb @@ -34,23 +34,4 @@ module Vmpooler $stderr.puts "Failure updating timing #{prefix}.#{label} on statsd server [#{server}:#{port}]: #{err}" end end - - class DummyStatsd - attr_reader :server, :port, :prefix - - def initialize(params = {}) - end - - def increment(label) - true - end - - def gauge(label, value) - true - end - - def timing(label, duration) - true - end - end end