puppetlabs/vmpooler
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler.git synced 2026-01-27 10:28:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

(MAINT) Make Port Check Configurable

Browse source 
This change makes the port and port timeout configurable via the YAML
config file. Before these were hard coded to 22 and 5, respectively.

Tests have been added to verify the default is chosen when not
configured and the configuration is picked up when supplied.
This commit is contained in:
Colin 2015-12-21 11:35:33 -08:00
parent 1a6cd99ed2
commit f580f9915e
3 changed files with 50 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

31
spec/vmpooler/pool_manager_spec.rb
View file

@ -33,16 +33,43 @@ describe 'Pool Manager' do
end
context 'host is in pool' do
context 'host is in pool (defaults)' do
let(:vm_finder) { double('vm_finder') }
let(:tcpsocket) { double('TCPSocket') }
let(:config) { {config: {}} }
it 'calls move_pending_vm_to_ready' do
stub_const("TCPSocket", tcpsocket)
allow(pool_helper).to receive(:find_vm).and_return(vm_finder)
allow(vm_finder).to receive(:summary).and_return(nil)
allow(tcpsocket).to receive(:new).and_return(true)
# ensure the default port was used
allow(tcpsocket).to receive(:new).with(String, 22).and_return(true)
expect(vm_finder).to receive(:summary).once
expect(redis).not_to receive(:hget).with(String, 'clone')
subject._check_pending_vm(vm, pool, timeout)
end
end
context 'host is in pool (port config)' do
let(:vm_finder) { double('vm_finder') }
let(:tcpsocket) { double('TCPSocket') }
# port and port timeout are now configurable.
# update the config mock
let(:port_no) { 99 }
let(:config) { {config: {
'port' => port_no,
'port_timeout' => 2}} }
it 'calls move_pending_vm_to_ready' do
stub_const("TCPSocket", tcpsocket)
allow(pool_helper).to receive(:find_vm).and_return(vm_finder)
allow(vm_finder).to receive(:summary).and_return(nil)
# ensure the port config made it to the TCPSocket call:
allow(tcpsocket).to receive(:new).with(String, port_no).and_return(true)
expect(vm_finder).to receive(:summary).once
expect(redis).not_to receive(:hget).with(String, 'clone')