puppetlabs/vmpooler
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler.git synced 2026-01-27 02:18:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

(MOB) refactor create_inventory into own method

Browse source 
Takes the #INVENTORY section from
the _check_pool method & splits
it into its own method
This commit is contained in:
kevpl 2018-06-19 11:00:16 -07:00
parent 678290f779
commit ec07f04d95
2 changed files with 39 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

26
spec/unit/pool_manager_spec.rb
View file

@ -2651,6 +2651,17 @@ EOT
end
end
describe '#create_inventory' do
it 'should log an error if one occurs' # do
# expect(provider).to receive(:vms_in_pool).and_raise(RuntimeError,'Mock Error')
# expect(logger).to receive(:log).with('s', "[!] [#{pool}] _check_pool failed with an error while running create_inventory: Mock Error")
#
# subject._check_pool(pool_object,provider)
# end
end
describe '#_check_pool' do
let(:new_vm_response) {
# Mock response from Base Provider for vms_in_pool
@ -2703,11 +2714,18 @@ EOT
allow(provider).to receive(:vms_in_pool).with(pool).and_return(new_vm_response)
end
it 'should log an error if one occurs' do
expect(provider).to receive(:vms_in_pool).and_raise(RuntimeError,'Mock Error')
expect(logger).to receive(:log).with('s', "[!] [#{pool}] _check_pool failed with an error while inspecting inventory: Mock Error")
it 'calls inventory correctly' do
expect(subject).to receive(:create_inventory)
subject._check_pool(pool_object, provider)
end
subject._check_pool(pool_object,provider)
it 'passes #create_inventory errors correctly' do
allow(subject).to receive(:create_inventory).and_raise(
RuntimeError,'Mock Error'
)
expect {
subject._check_pool(pool_object, provider)
}.to raise_error(RuntimeError, /Mock Error/)
end
it 'should not perform any other actions if an error occurs' do