puppetlabs/vmpooler
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler.git synced 2026-01-26 01:58:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

(QENG-1906) Break apart check_pending_vm and add spec tests

Browse source 
This commit breaks apart the method check_pending_vm in to three,
smaller methods that are easier to test. There are no functionality
changes or bug fixes.

This adds spec tests for the overall functionality that was
check_pending_vm.
This commit is contained in:
Colin 2015-04-01 15:42:28 -07:00
parent 8facda429e
commit e6ee6b1257
2 changed files with 185 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

60
lib/vmpooler/pool_manager.rb
View file

@ -25,40 +25,50 @@ module Vmpooler
# Check the state of a VM
def check_pending_vm(vm, pool, timeout)
Thread.new do
host = $vsphere[pool].find_vm(vm)
_check_pending_vm(vm, pool, timeout)
end
end
if host
if
(host.summary) &&
(host.summary.guest) &&
(host.summary.guest.hostName) &&
(host.summary.guest.hostName == vm)
def _check_pending_vm(vm, pool, timeout)
host = $vsphere[pool].find_vm(vm)
begin
Socket.getaddrinfo(vm, nil)
rescue
end
if host
move_pending_vm_to_ready(vm, pool, host)
else
fail_pending_vm(vm, pool, timeout)
end
end
clone_time = $redis.hget('vmpooler__vm__' + vm, 'clone')
finish = '%.2f' % (Time.now - Time.parse(clone_time)) if clone_time
def fail_pending_vm(vm, pool, timeout)
clone_stamp = $redis.hget('vmpooler__vm__' + vm, 'clone')
$redis.smove('vmpooler__pending__' + pool, 'vmpooler__ready__' + pool, vm)
$redis.hset('vmpooler__boot__' + Date.today.to_s, pool + ':' + vm, finish)
if (clone_stamp) &&
(((Time.now - Time.parse(clone_stamp)) / 60) > timeout)
$logger.log('s', "[>] [#{pool}] '#{vm}' moved to 'ready' queue")
end
else
clone_stamp = $redis.hget('vmpooler__vm__' + vm, 'clone')
$redis.smove('vmpooler__pending__' + pool, 'vmpooler__completed__' + pool, vm)
if
(clone_stamp) &&
(((Time.now - Time.parse(clone_stamp)) / 60) > timeout)
$logger.log('d', "[!] [#{pool}] '#{vm}' marked as 'failed' after #{timeout} minutes")
end
end
$redis.smove('vmpooler__pending__' + pool, 'vmpooler__completed__' + pool, vm)
def move_pending_vm_to_ready(vm, pool, host)
if (host.summary) &&
(host.summary.guest) &&
(host.summary.guest.hostName) &&
(host.summary.guest.hostName == vm)
$logger.log('d', "[!] [#{pool}] '#{vm}' marked as 'failed' after #{timeout} minutes")
end
begin
Socket.getaddrinfo(vm, nil)
rescue
end
clone_time = $redis.hget('vmpooler__vm__' + vm, 'clone')
finish = '%.2f' % (Time.now - Time.parse(clone_time)) if clone_time
$redis.smove('vmpooler__pending__' + pool, 'vmpooler__ready__' + pool, vm)
$redis.hset('vmpooler__boot__' + Date.today.to_s, pool + ':' + vm, finish)
$logger.log('s', "[>] [#{pool}] '#{vm}' moved to 'ready' queue")
end
end