(POOLER-70) Rename conflicting method in vSphere Provider

Previously, the vSphere Provider had two methods called
`find_least_used_compatible_host`: one in the base class and one in the vSphere
helper methods.  This commit renames the vSphere helper methods and tests to
`find_least_used_vsphere_compatible_host` to stop the conflict.

lib/vmpooler/providers/vsphere.rb

@@ -265,7 +265,7 @@ module Vmpooler
           cluster_hosts
         end
 
-        def find_least_used_compatible_host(vm)
+        def find_least_used_vpshere_compatible_host(vm)
           ensure_connected @connection, @credentials
 
           source_host = vm.summary.runtime.host

spec/unit/providers/vsphere_spec.rb

@@ -107,6 +107,7 @@ EOT
 
       expect(subject.vm_exists?('vm')).to eq(false)
     end
+  end
 
   # vSphere helper methods
   let(:credentials) { config[:vsphere] }
@@ -1389,7 +1390,7 @@ EOT
     end
   end
 
-    describe '#find_least_used_compatible_host' do
+  describe '#find_least_used_vpshere_compatible_host' do
     let(:vm) { mock_RbVmomi_VIM_VirtualMachine() }
 
     before(:each) do
@@ -1407,7 +1408,7 @@ EOT
       end
 
       it 'should return the standalone host' do
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
 
         expect(result).to_not be_nil
         expect(result[0]).to be(standalone_host)
@@ -1417,7 +1418,7 @@ EOT
       it 'should ensure the connection' do
         expect(subject).to receive(:ensure_connected)
 
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
       end
     end
 
@@ -1433,7 +1434,7 @@ EOT
       end
 
       it 'should raise error' do
-          expect{subject.find_least_used_compatible_host(vm)}.to raise_error(NoMethodError,/undefined method/)
+        expect{subject.find_least_used_vpshere_compatible_host(vm)}.to raise_error(NoMethodError,/undefined method/)
       end
     end
 
@@ -1451,7 +1452,7 @@ EOT
       end
 
       it 'should return the least used host' do
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
 
         expect(result).to_not be_nil
         expect(result[0]).to be(expected_host)
@@ -1461,7 +1462,7 @@ EOT
       it 'should ensure the connection' do
         expect(subject).to receive(:ensure_connected)
 
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
       end
     end
 
@@ -1479,7 +1480,7 @@ EOT
       end
 
       it 'should raise error' do
-          expect{subject.find_least_used_compatible_host(vm)}.to raise_error(NoMethodError,/undefined method/)
+        expect{subject.find_least_used_vpshere_compatible_host(vm)}.to raise_error(NoMethodError,/undefined method/)
       end
     end
 
@@ -1499,7 +1500,7 @@ EOT
       end
 
       it 'should return the least used host' do
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
 
         expect(result).to_not be_nil
         expect(result[0]).to be(expected_host)
@@ -1509,7 +1510,7 @@ EOT
       it 'should ensure the connection' do
         expect(subject).to receive(:ensure_connected)
 
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
       end
     end
 
@@ -1528,7 +1529,7 @@ EOT
 
       it 'should return a host' do
         pending('https://github.com/puppetlabs/vmpooler/issues/206 is fixed')
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
 
         expect(result).to_not be_nil
       end
@@ -1537,7 +1538,7 @@ EOT
         pending('https://github.com/puppetlabs/vmpooler/issues/206 is fixed')
         expect(subject).to receive(:ensure_connected)
 
-          result = subject.find_least_used_compatible_host(vm)
+        result = subject.find_least_used_vpshere_compatible_host(vm)
       end
     end
   end
@@ -2185,5 +2186,4 @@ EOT
       end
     end
   end
-  end
 end