(QENG-2995) Display associated VMs in GET /token/:token endpoint

This commit is contained in:
Scott Schneider 2015-11-04 12:35:35 -08:00
parent 12da1e07d2
commit e0356968df
3 changed files with 33 additions and 8 deletions

11
API.md
View file

@ -40,7 +40,7 @@ Enter host password for user 'jdoe':
##### GET /token/<token> ##### GET /token/<token>
Get information about an existing token. Get information about an existing token (including associated VMs).
``` ```
$ curl -u jdoe --url vmpooler.company.com/api/v1/token/utpg2i2xswor6h8ttjhu3d47z53yy47y $ curl -u jdoe --url vmpooler.company.com/api/v1/token/utpg2i2xswor6h8ttjhu3d47z53yy47y
@ -51,7 +51,14 @@ Enter host password for user 'jdoe':
"ok": true, "ok": true,
"utpg2i2xswor6h8ttjhu3d47z53yy47y": { "utpg2i2xswor6h8ttjhu3d47z53yy47y": {
"user": "jdoe", "user": "jdoe",
"timestamp": "2015-04-28 19:17:47 -0700" "created": "2015-04-28 19:17:47 -0700",
"last": "2015-11-04 12:28:37 -0700",
"vms": {
"running": [
"dqs4914g2wjyy5w",
"hul7ib0ssr0f4o0"
]
}
} }
} }
``` ```

View file

@ -209,6 +209,17 @@ module Vmpooler
if not token.nil? and not token.empty? if not token.nil? and not token.empty?
status 200 status 200
pools.each do |pool|
backend.smembers('vmpooler__running__' + pool['name']).each do |vm|
if backend.hget('vmpooler__vm__' + vm, 'token:token') == params[:token]
token['vms'] ||= {}
token['vms']['running'] ||= []
token['vms']['running'].push(vm)
end
end
end
result = { 'ok' => true, params[:token] => token } result = { 'ok' => true, params[:token] => token }
else else
status 404 status 404

View file

@ -120,11 +120,12 @@ describe Vmpooler::API::V1 do
end end
context '(auth configured)' do context '(auth configured)' do
before do let(:config) { {
allow(redis).to receive(:hgetall).and_return 'atoken' auth: true,
end pools: [
{'name' => 'pool1', 'size' => 5}
let(:config) { { auth: true } } ]
} }
it 'returns a 401 if not authed' do it 'returns a 401 if not authed' do
get "#{prefix}/token/this" get "#{prefix}/token/this"
@ -133,11 +134,17 @@ describe Vmpooler::API::V1 do
end end
it 'returns a token if authed' do it 'returns a token if authed' do
expect(redis).to receive(:hgetall).with('vmpooler__token__this').and_return({'user' => 'admin'})
expect(redis).to receive(:smembers).with('vmpooler__running__pool1').and_return(['vmhostname'])
expect(redis).to receive(:hget).with('vmpooler__vm__vmhostname', 'token:token').and_return('this')
authorize 'admin', 's3cr3t' authorize 'admin', 's3cr3t'
get "#{prefix}/token/this" get "#{prefix}/token/this"
expect(last_response.body).to include('"this": "atoken"') expect(JSON.parse(last_response.body)['ok']).to eq(true)
expect(JSON.parse(last_response.body)['this']['user']).to eq('admin')
expect(JSON.parse(last_response.body)['this']['vms']['running']).to include('vmhostname')
expect_json(ok = true, http = 200) expect_json(ok = true, http = 200)
end end