puppetlabs/vmpooler
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler.git synced 2026-01-27 02:18:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed pool_manager_spec tests

Browse source
This commit is contained in:
Michelle Schuknecht 2018-07-17 09:36:15 -07:00
parent 481d5b215f
commit dc9b221bb9
2 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/vmpooler/pool_manager.rb
View file

@ -737,7 +737,7 @@ module Vmpooler
end end
end end
def check_ready_pool_vms(pool_name, provider, pool_check_response, inventory, pool_ttl) def check_ready_pool_vms(pool_name, provider, pool_check_response, inventory, pool_ttl = nil)
# READY # READY
$redis.smembers("vmpooler__ready__#{pool_name}").each do |vm| $redis.smembers("vmpooler__ready__#{pool_name}").each do |vm|
if inventory[vm] if inventory[vm]

26
spec/unit/pool_manager_spec.rb
View file

@ -2746,12 +2746,12 @@ EOT
let(:pool_check_response) { let(:pool_check_response) {
{:checked_ready_vms => 0} {:checked_ready_vms => 0}
} }
context 'Ready VM not in the inventory' do
let(:inventory) { let(:inventory) {
# mock response from create_inventory # mock response from create_inventory
{} {}
} }
context 'Ready VM not in the inventory' do
before(:each) do before(:each) do
create_ready_vm(pool,vm,token) create_ready_vm(pool,vm,token)
end end
@ -2759,24 +2759,31 @@ EOT
it 'should not call check_ready_vm' do it 'should not call check_ready_vm' do
expect(subject).to receive(:check_ready_vm).exactly(0).times expect(subject).to receive(:check_ready_vm).exactly(0).times
subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory, ttl) subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory)
end end
it 'should move the VM to completed queue' do it 'should move the VM to completed queue' do
expect(subject).to receive(:move_vm_queue).with(pool,vm,'ready','completed',String).and_call_original expect(subject).to receive(:move_vm_queue).with(pool,vm,'ready','completed',String).and_call_original
subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory, ttl) subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory)
end end
end end
context 'Ready VM in the inventory' do context 'Ready VM in the inventory' do
let(:inventory) {
# mock response from create_inventory
{vm => 1}
}
let(:big_lifetime) {
2000
}
before(:each) do before(:each) do
allow(subject).to receive(:check_ready_vm) allow(subject).to receive(:check_ready_vm)
create_ready_vm(pool,vm,token) create_ready_vm(pool,vm,token)
end end
it 'should return the number of checked ready VMs' do it 'should return the number of checked ready VMs' do
subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory, ttl) subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory)
expect(pool_check_response[:checked_ready_vms]).to be(1) expect(pool_check_response[:checked_ready_vms]).to be(1)
end end
@ -2785,22 +2792,19 @@ EOT
expect(subject).to receive(:check_ready_vm).and_raise(RuntimeError,'MockError') expect(subject).to receive(:check_ready_vm).and_raise(RuntimeError,'MockError')
expect(logger).to receive(:log).with('d', "[!] [#{pool}] _check_pool failed with an error while evaluating ready VMs: MockError") expect(logger).to receive(:log).with('d', "[!] [#{pool}] _check_pool failed with an error while evaluating ready VMs: MockError")
subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory, ttl) subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory)
end end
it 'should use the pool TTL if set' do it 'should use the pool TTL if set' do
big_lifetime = 2000
config[:pools][0]['ready_ttl'] = big_lifetime
expect(subject).to receive(:check_ready_vm).with(vm,pool,big_lifetime,provider) expect(subject).to receive(:check_ready_vm).with(vm,pool,big_lifetime,provider)
subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory, ttl) subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory, big_lifetime)
end end
it 'should use a pool TTL of zero if none set' do it 'should use a pool TTL of zero if none set' do
expect(subject).to receive(:check_ready_vm).with(vm,pool,0,provider) expect(subject).to receive(:check_ready_vm).with(vm,pool,0,provider)
subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory, ttl) subject.check_ready_pool_vms(pool, provider, pool_check_response, inventory)
end end
end end
end end