puppetlabs/vmpooler
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler.git synced 2026-01-26 18:08:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Correct keyword arguments to traverse in create_folder

Browse source 
This commit fixes this call to `dc.vmFolder.traverse` to simply pass in
the arguements instead of assigning to variables that are discarded.
This commit is contained in:
Brandon High 2020-03-05 11:55:31 -08:00
parent 5dca8f9468
commit daa1a99073
No known key found for this signature in database
GPG key ID: 270079C784FCAFDE
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/vmpooler/providers/vsphere.rb
View file

@ -1024,7 +1024,7 @@ module Vmpooler
def create_folder(connection, new_folder, datacenter) def create_folder(connection, new_folder, datacenter)
dc = connection.serviceInstance.find_datacenter(datacenter) dc = connection.serviceInstance.find_datacenter(datacenter)
folder_object = dc.vmFolder.traverse(new_folder, type = RbVmomi::VIM::Folder, create = true) folder_object = dc.vmFolder.traverse(new_folder, RbVmomi::VIM::Folder, true)
raise("Cannot create folder #{new_folder}") if folder_object.nil? raise("Cannot create folder #{new_folder}") if folder_object.nil?
folder_object folder_object

4
spec/unit/providers/vsphere_spec.rb
View file

@ -2715,7 +2715,7 @@ EOT
it 'creates a folder' do it 'creates a folder' do
expect(connection.serviceInstance).to receive(:find_datacenter).with(datacenter).and_return(datacenter_object) expect(connection.serviceInstance).to receive(:find_datacenter).with(datacenter).and_return(datacenter_object)
expect(datacenter_object.vmFolder).to receive(:traverse).with(new_folder, type=RbVmomi::VIM::Folder, create=true).and_return(folder_object) expect(datacenter_object.vmFolder).to receive(:traverse).with(new_folder, RbVmomi::VIM::Folder, true).and_return(folder_object)
result = subject.create_folder(connection, new_folder, datacenter) result = subject.create_folder(connection, new_folder, datacenter)
expect(result).to eq(folder_object) expect(result).to eq(folder_object)
@ -2724,7 +2724,7 @@ EOT
context 'with folder_object returning nil' do context 'with folder_object returning nil' do
it 'shoud raise an error' do it 'shoud raise an error' do
expect(connection.serviceInstance).to receive(:find_datacenter).with(datacenter).and_return(datacenter_object) expect(connection.serviceInstance).to receive(:find_datacenter).with(datacenter).and_return(datacenter_object)
expect(datacenter_object.vmFolder).to receive(:traverse).with(new_folder, type=RbVmomi::VIM::Folder, create=true).and_return(nil) expect(datacenter_object.vmFolder).to receive(:traverse).with(new_folder, RbVmomi::VIM::Folder, true).and_return(nil)
expect{subject.create_folder(connection, new_folder, datacenter)}.to raise_error("Cannot create folder #{new_folder}") expect{subject.create_folder(connection, new_folder, datacenter)}.to raise_error("Cannot create folder #{new_folder}")
end end