(QENG-2208) Add more helper tests

Add tests for more Helper methods. This moves line coverage to 59%,
leaving only get_task_metrics remaining.

spec/vmpooler/api/helpers_spec.rb

@@ -37,4 +37,119 @@ describe Vmpooler::API::Helpers do
     end
   end
 
+  describe '#mean' do
+    [
+        [[1, 2, 3, 4], 2.5],
+        [[1], 1],
+        [[nil], 0],
+        [[], 0]
+    ].each do |list, expected|
+      it "returns #{expected.inspect} for #{list.inspect}" do
+        expect(subject.mean(list)).to eq expected
+      end
+    end
+  end
+
+  describe '#get_task_times' do
+    let(:redis) { double('redis') }
+    [
+        ['task1', '2014-01-01', [1, 2, 3, 4], [1.0, 2.0, 3.0, 4.0]],
+        ['task1', 'some date', [], []],
+        ['task1', 'date', [2.2], [2.2]],
+        ['task1', 'date', [2.2, 3, 3.0], [2.2, 3.0, 3.0]]
+    ].each do |task, date, time_list, expected|
+      it "returns #{expected.inspect} for task #{task.inspect}@#{date.inspect}" do
+        allow(redis).to receive(:hvals).and_return time_list
+        expect(subject.get_task_times(redis, task, date)).to eq expected
+      end
+    end
+  end
+
+  describe '#get_capacity_metrics' do
+    let(:redis) { double('redis') }
+
+    it 'adds up pools correctly' do
+      pools = [
+          {'name' => 'p1', 'size' => 5},
+          {'name' => 'p2', 'size' => 5}
+      ]
+
+      allow(redis).to receive(:scard).with('vmpooler__ready__p1').and_return 1
+      allow(redis).to receive(:scard).with('vmpooler__ready__p2').and_return 1
+
+      expect(subject.get_capacity_metrics(pools, redis)).to eq({current: 2, total: 10, percent: 20.0})
+    end
+
+    it 'handles 0 from redis' do
+      pools = [
+          {'name' => 'p1', 'size' => 5},
+          {'name' => 'p2', 'size' => 5}
+      ]
+
+      allow(redis).to receive(:scard).with('vmpooler__ready__p1').and_return 1
+      allow(redis).to receive(:scard).with('vmpooler__ready__p2').and_return 0
+
+      expect(subject.get_capacity_metrics(pools, redis)).to eq({current: 1, total: 10, percent: 10.0})
+    end
+
+    it 'handles 0 size' do
+      pools = [
+          {'name' => 'p1', 'size' => 5},
+          {'name' => 'p2', 'size' => 0}
+      ]
+
+      allow(redis).to receive(:scard).with('vmpooler__ready__p1').and_return 1
+      allow(redis).to receive(:scard).with('vmpooler__ready__p2').and_return 0
+
+      expect(subject.get_capacity_metrics(pools, redis)).to eq({current: 1, total: 5, percent: 20.0})
+    end
+
+    it 'handles empty pool array' do
+      expect(subject.get_capacity_metrics([], redis)).to eq({current: 0, total: 0, percent: 0})
+    end
+  end
+
+  describe '#get_queue_metrics' do
+    let(:redis) { double('redis') }
+
+    it 'handles empty pool array' do
+      allow(redis).to receive(:scard).and_return 0
+      allow(redis).to receive(:get).and_return 0
+
+      expect(subject.get_queue_metrics([], redis)).to eq({pending: 0, cloning: 0, booting: 0, ready: 0, running: 0, completed: 0, total: 0})
+    end
+
+    it 'adds pool queues correctly' do
+      pools = [
+          {'name' => 'p1'},
+          {'name' => 'p2'}
+      ]
+
+      pools.each do |p|
+        %w(pending ready running completed).each do |action|
+          allow(redis).to receive(:scard).with('vmpooler__' + action + '__' + p['name']).and_return 1
+        end
+      end
+      allow(redis).to receive(:get).and_return 1
+
+      expect(subject.get_queue_metrics(pools, redis)).to eq({pending: 2, cloning: 1, booting: 1, ready: 2, running: 2, completed: 2, total: 8})
+    end
+
+    it 'sets booting to 0 when negative calculation' do
+      pools = [
+          {'name' => 'p1'},
+          {'name' => 'p2'}
+      ]
+
+      pools.each do |p|
+        %w(pending ready running completed).each do |action|
+          allow(redis).to receive(:scard).with('vmpooler__' + action + '__' + p['name']).and_return 1
+        end
+      end
+      allow(redis).to receive(:get).and_return 5
+
+      expect(subject.get_queue_metrics(pools, redis)).to eq({pending: 2, cloning: 5, booting: 0, ready: 2, running: 2, completed: 2, total: 8})
+    end
+  end
+
 end