From b9d86c85ecba9a9e12bebee8600dea242bced42d Mon Sep 17 00:00:00 2001
From: Spencer McElmurry <mcelmurs@gmail.com>
Date: Fri, 29 Jun 2018 15:13:44 -0700
Subject: [PATCH] Fixed spec testing for check_running_pool_vm

---
 spec/unit/pool_manager_spec.rb | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/spec/unit/pool_manager_spec.rb b/spec/unit/pool_manager_spec.rb
index d92d46e..404d17b 100644
--- a/spec/unit/pool_manager_spec.rb
+++ b/spec/unit/pool_manager_spec.rb
@@ -2665,22 +2665,15 @@ EOT
   end
 
   describe '#check_running_pool_vms' do
-    let(:new_vm_response) {
-      # Mock response from Base Provider for vms_in_pool
-      [{ 'name' => vm}]
-    }
-    let(:inventory) {
-      # mock response from create_inventory
-      {vm => 1}
-    }
     let(:pool_check_response) {
       {:checked_running_vms => 0}
     }
-
     context 'Running VM not in the inventory' do
+      let(:inventory) {
+        # mock response from create_inventory
+        {}
+      }
       before(:each) do
-        expect(provider).to receive(:vms_in_pool).with(pool).and_return(new_vm_response)
-        expect(logger).to receive(:log).with('s', "[?] [#{pool}] '#{vm}' added to 'discovered' queue")
         create_running_vm(pool,vm,token)
       end
 
@@ -2693,13 +2686,17 @@ EOT
       it 'should move the VM to completed queue' do
         expect(subject).to receive(:move_vm_queue).with(pool,vm,'running','completed',String).and_call_original
 
-        subject._check_pool(pool_object,provider)
+        subject.check_running_pool_vms(pool,provider, pool_check_response, inventory)
       end
     end
 
     context 'Running VM in the inventory' do
+      let(:provider) { double('provider') }
+      let(:inventory) {
+        # mock response from create_inventory
+        { vm => 1 }
+      }
       before(:each) do
-        expect(provider).to receive(:vms_in_pool).with(pool).and_return(vm_response)
         allow(subject).to receive(:check_running_vm)
         create_running_vm(pool,vm,token)
       end
@@ -2708,7 +2705,7 @@ EOT
         expect(subject).to receive(:check_running_vm).and_raise(RuntimeError,'MockError')
         expect(logger).to receive(:log).with('d', "[!] [#{pool}] _check_pool with an error while evaluating running VMs: MockError")
 
-        subject._check_pool(pool_object,provider)
+        subject.check_running_pool_vms(pool, provider, pool_check_response, inventory)
       end
 
       it 'should return the number of checked running VMs' do