From 9201a0befbdbb41675912a8df3084e84f7d9661b Mon Sep 17 00:00:00 2001 From: Brandon High Date: Wed, 4 Mar 2020 12:06:54 -0800 Subject: [PATCH] Rubocop 0.80 updates to rubocop configs Arbitrary annoying name changes to cops and new cops that I don't think we would care about: https://rubocop.readthedocs.io/en/latest/cops_style/#stylehasheachmethods https://rubocop.readthedocs.io/en/latest/cops_style/#stylehashtransformkeys https://rubocop.readthedocs.io/en/latest/cops_style/#stylehashtransformvalues --- .rubocop.yml | 13 ++++++++++++- .rubocop_todo.yml | 26 +++----------------------- 2 files changed, 15 insertions(+), 24 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index e588c52..a79ebcf 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -17,7 +17,7 @@ Style/Documentation: Enabled: false # Line length is not useful -Metrics/LineLength: +Layout/LineLength: Enabled: false # Empty method definitions over more than one line is ok @@ -69,3 +69,14 @@ Style/GuardClause: Layout/EndOfLine: EnforcedStyle: lf +# Added in 0.80, don't really care about the change +Style/HashEachMethods: + Enabled: false + +# Added in 0.80, don't really care about the change +Style/HashTransformKeys: + Enabled: false + +# Added in 0.80, don't really care about the change +Style/HashTransformValues: + Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2c162d6..6105e46 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -10,7 +10,7 @@ # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: with_first_parameter, with_fixed_indentation -Layout/AlignParameters: +Layout/ParameterAlignment: Exclude: - 'lib/vmpooler/api/v1.rb' @@ -55,7 +55,7 @@ Layout/EmptyLinesAroundModuleBody: # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces -Layout/IndentFirstHashElement: +Layout/FirstHashElementIndentation: Exclude: - 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/v1.rb' @@ -96,12 +96,6 @@ Layout/SpaceAroundOperators: Exclude: - 'lib/vmpooler/api/v1.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Layout/SpaceInsideBrackets: - Exclude: - - 'lib/vmpooler/api/v1.rb' - # Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces. @@ -125,7 +119,7 @@ Lint/AssignmentInCondition: - 'lib/vmpooler/api/v1.rb' # Offense count: 2 -Lint/HandleExceptions: +Lint/SuppressedException: Exclude: - 'lib/vmpooler/api/dashboard.rb' @@ -147,12 +141,6 @@ Lint/UselessAssignment: - 'lib/vmpooler/api/dashboard.rb' - 'lib/vmpooler/api/helpers.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Performance/RedundantMatch: - Exclude: - - 'lib/vmpooler/api/v1.rb' - # Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. @@ -162,14 +150,6 @@ Style/AndOr: - 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/v1.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: braces, no_braces, context_dependent -Style/BracesAroundHashParameters: - Exclude: - - 'lib/vmpooler/api/v1.rb' - # Offense count: 1 Style/CaseEquality: Exclude: