From 8c79acd02de370a0ab54761a45af6a4d71ed0779 Mon Sep 17 00:00:00 2001 From: Dakota Schneider Date: Tue, 19 Jun 2018 11:52:40 -0700 Subject: [PATCH] Fixup spec for pool_check_response --- spec/unit/pool_manager_spec.rb | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/spec/unit/pool_manager_spec.rb b/spec/unit/pool_manager_spec.rb index 21ce1ad..214453f 100644 --- a/spec/unit/pool_manager_spec.rb +++ b/spec/unit/pool_manager_spec.rb @@ -2221,25 +2221,21 @@ EOT subject._check_pool(pool_object, provider) end - it 'passes #create_inventory errors correctly' do + it 'captures #create_inventory errors correctly' do allow(subject).to receive(:create_inventory).and_raise( RuntimeError,'Mock Error' ) expect { subject._check_pool(pool_object, provider) - }.to raise_error(RuntimeError, /Mock Error/) + }.to_not raise_error(RuntimeError, /Mock Error/) end - it 'should not perform any other actions if an error occurs' do + it 'should return early if an error occurs' do allow(subject).to receive(:create_inventory).and_raise( RuntimeError,'Mock Error' ) - - expect { - subject._check_pool(pool_object, provider) - }.to raise_error(RuntimeError, /Mock Error/) - expect(subject).to_not receive(:check_running_pool_vms) + subject._check_pool(pool_object, provider) end it 'should return that no actions were taken' do