puppetlabs/vmpooler
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler.git synced 2026-01-26 18:08:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

(QENG-1873) Fix /0 Error

Browse source 
Calculate total count before trying to use it in average calculation.
This commit is contained in:
Colin 2015-02-24 09:26:50 -08:00
parent 5db5df826f
commit 85ac329894
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/vmpooler/api.rb
View file

@ -309,12 +309,15 @@ module Vmpooler
# again, calc clone_average if we had clones. # again, calc clone_average if we had clones.
unless total_clones_per_day.nil? or total_clones_per_day.length == 0 unless total_clones_per_day.nil? or total_clones_per_day.length == 0
# totals
result[:clone][:count][:total] = total_clones_per_day.reduce(:+).to_i
result[:clone][:duration][:total] = total_clone_dur_day.reduce(:+).to_f
# averages and other things.
result[:clone][:duration][:average] = result[:clone][:duration][:total] / result[:clone][:count][:total] result[:clone][:duration][:average] = result[:clone][:duration][:total] / result[:clone][:count][:total]
result[:clone][:duration][:min], result[:clone][:duration][:max] = min_max_clone_times.minmax result[:clone][:duration][:min], result[:clone][:duration][:max] = min_max_clone_times.minmax
result[:clone][:duration][:total] = total_clone_dur_day.reduce(:+).to_f
result[:clone][:count][:min], result[:clone][:count][:max] = total_clones_per_day.minmax result[:clone][:count][:min], result[:clone][:count][:max] = total_clones_per_day.minmax
result[:clone][:count][:average] = mean(total_clones_per_day) result[:clone][:count][:average] = mean(total_clones_per_day)
result[:clone][:count][:total] = total_clones_per_day.reduce(:+).to_i
end end
content_type :json content_type :json