From cec7183fdc9e92abf40f98f1f1b1806766cb6847 Mon Sep 17 00:00:00 2001 From: Brandon High Date: Wed, 4 Mar 2020 11:44:36 -0800 Subject: [PATCH 1/3] Release 0.10.3 Updates for release 0.10.3, tagging will be handled by the job. --- CHANGELOG.md | 9 ++++++++- lib/vmpooler/version.rb | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 92f6a0d..4e16d5e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,14 @@ Tracking in this Changelog began for this project with the tagging of version 0. If you're looking for changes from before this, refer to the project's git logs & PR history. -## [Unreleased](https://github.com/puppetlabs/vmpooler/compare/0.10.0...master) +## [Unreleased](https://github.com/puppetlabs/vmpooler/compare/0.10.3...master) + +## [0.10.3](https://github.com/puppetlabs/vmpooler/compare/0.10.2...0.10.3) + +- Fix Redis update during migration to better reflect actual state (POOLER-154) + +## [0.10.2](https://github.com/puppetlabs/vmpooler/compare/0.10.1...0.10.2) +- Version bump (no code changes) ## [0.10.1](https://github.com/puppetlabs/vmpooler/compare/0.10.0...0.10.1) diff --git a/lib/vmpooler/version.rb b/lib/vmpooler/version.rb index 9434008..2b2306c 100644 --- a/lib/vmpooler/version.rb +++ b/lib/vmpooler/version.rb @@ -1,3 +1,3 @@ module Vmpooler - VERSION = '0.10.2'.freeze + VERSION = '0.10.3'.freeze end From 9201a0befbdbb41675912a8df3084e84f7d9661b Mon Sep 17 00:00:00 2001 From: Brandon High Date: Wed, 4 Mar 2020 12:06:54 -0800 Subject: [PATCH 2/3] Rubocop 0.80 updates to rubocop configs Arbitrary annoying name changes to cops and new cops that I don't think we would care about: https://rubocop.readthedocs.io/en/latest/cops_style/#stylehasheachmethods https://rubocop.readthedocs.io/en/latest/cops_style/#stylehashtransformkeys https://rubocop.readthedocs.io/en/latest/cops_style/#stylehashtransformvalues --- .rubocop.yml | 13 ++++++++++++- .rubocop_todo.yml | 26 +++----------------------- 2 files changed, 15 insertions(+), 24 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index e588c52..a79ebcf 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -17,7 +17,7 @@ Style/Documentation: Enabled: false # Line length is not useful -Metrics/LineLength: +Layout/LineLength: Enabled: false # Empty method definitions over more than one line is ok @@ -69,3 +69,14 @@ Style/GuardClause: Layout/EndOfLine: EnforcedStyle: lf +# Added in 0.80, don't really care about the change +Style/HashEachMethods: + Enabled: false + +# Added in 0.80, don't really care about the change +Style/HashTransformKeys: + Enabled: false + +# Added in 0.80, don't really care about the change +Style/HashTransformValues: + Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2c162d6..6105e46 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -10,7 +10,7 @@ # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: with_first_parameter, with_fixed_indentation -Layout/AlignParameters: +Layout/ParameterAlignment: Exclude: - 'lib/vmpooler/api/v1.rb' @@ -55,7 +55,7 @@ Layout/EmptyLinesAroundModuleBody: # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces -Layout/IndentFirstHashElement: +Layout/FirstHashElementIndentation: Exclude: - 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/v1.rb' @@ -96,12 +96,6 @@ Layout/SpaceAroundOperators: Exclude: - 'lib/vmpooler/api/v1.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Layout/SpaceInsideBrackets: - Exclude: - - 'lib/vmpooler/api/v1.rb' - # Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces. @@ -125,7 +119,7 @@ Lint/AssignmentInCondition: - 'lib/vmpooler/api/v1.rb' # Offense count: 2 -Lint/HandleExceptions: +Lint/SuppressedException: Exclude: - 'lib/vmpooler/api/dashboard.rb' @@ -147,12 +141,6 @@ Lint/UselessAssignment: - 'lib/vmpooler/api/dashboard.rb' - 'lib/vmpooler/api/helpers.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Performance/RedundantMatch: - Exclude: - - 'lib/vmpooler/api/v1.rb' - # Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. @@ -162,14 +150,6 @@ Style/AndOr: - 'lib/vmpooler/api/helpers.rb' - 'lib/vmpooler/api/v1.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: braces, no_braces, context_dependent -Style/BracesAroundHashParameters: - Exclude: - - 'lib/vmpooler/api/v1.rb' - # Offense count: 1 Style/CaseEquality: Exclude: From b613a2dc07d78e31bbe5ab8607fd20b666888f7c Mon Sep 17 00:00:00 2001 From: Brandon High Date: Wed, 4 Mar 2020 12:14:23 -0800 Subject: [PATCH 3/3] Update CHANGELOG for 0.10.3 (again) --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4e16d5e..3d5ef30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ git logs & PR history. ## [0.10.3](https://github.com/puppetlabs/vmpooler/compare/0.10.2...0.10.3) - Fix Redis update during migration to better reflect actual state (POOLER-154) +- Update Rubocop config, now we can actually see all the failing cops ## [0.10.2](https://github.com/puppetlabs/vmpooler/compare/0.10.1...0.10.2) - Version bump (no code changes)