From 6f3d853271c78724280b116c3ec32a3d65a94839 Mon Sep 17 00:00:00 2001
From: Jake Spain <jake.spain+15749776@perforce.com>
Date: Wed, 15 Feb 2023 09:45:03 -0500
Subject: [PATCH] Do not create/delete records if using dynamic dns

---
 lib/vmpooler/pool_manager.rb | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/lib/vmpooler/pool_manager.rb b/lib/vmpooler/pool_manager.rb
index 4fab1b0..bdbecc3 100644
--- a/lib/vmpooler/pool_manager.rb
+++ b/lib/vmpooler/pool_manager.rb
@@ -114,9 +114,10 @@ module Vmpooler
     def remove_nonexistent_vm(vm, pool, redis)
       redis.srem("vmpooler__pending__#{pool}", vm)
       dns_plugin = get_dns_plugin_class_for_pool(pool)
+      dns_plugin_class_name = get_dns_plugin_class_name_for_pool(pool)
       domain = get_dns_plugin_domain_for_pool(pool)
       fqdn = vm + '.' + domain
-      dns_plugin.delete_record(fqdn)
+      dns_plugin.delete_record(fqdn) unless dns_plugin_class_name == 'dynamic-dns'
       $logger.log('d', "[!] [#{pool}] '#{vm}' no longer exists. Removing from pending.")
     end
 
@@ -459,7 +460,8 @@ module Vmpooler
 
           $metrics.timing("clone.#{pool_name}", finish)
 
-          dns_plugin.create_or_replace_record(new_vmname)
+          dns_plugin_class_name = get_dns_plugin_class_name_for_pool(pool_name)
+          dns_plugin.create_or_replace_record(new_vmname) unless dns_plugin_class_name == 'dynamic-dns'
         rescue StandardError
           @redis.with_metrics do |redis|
             redis.pipelined do |pipeline|
@@ -509,7 +511,9 @@ module Vmpooler
           provider.destroy_vm(pool, vm)
           domain = get_dns_plugin_domain_for_pool(pool)
           fqdn = vm + '.' + domain
-          dns_plugin.delete_record(fqdn)
+          
+          dns_plugin_class_name = get_dns_plugin_class_name_for_pool(pool)
+          dns_plugin.delete_record(fqdn) unless dns_plugin_class_name == 'dynamic-dns'
 
           redis.srem("vmpooler__completed__#{pool}", vm)
 
@@ -701,6 +705,15 @@ module Vmpooler
       $providers[provider_name]
     end
 
+    def get_dns_plugin_class_name_for_pool(pool_name)
+      pool = $config[:pools].find { |p| p['name'] == pool_name }
+      return nil unless pool
+
+      plugin_name = pool.fetch('dns_plugin')
+      plugin_class = Vmpooler::Dns.get_dns_plugin_class_by_name(config, plugin_name)
+      plugin_class
+    end
+
     def get_dns_plugin_class_for_pool(pool_name)
       pool = $config[:pools].find { |p| p['name'] == pool_name }
       return nil unless pool