(POOLER-114) finish #repopulate_pool_vms refactor

also refactored the looping
structure within the method
This commit is contained in:
kevpl 2018-07-31 11:03:14 -07:00
parent 1890344d7d
commit 3b4200bd72
No known key found for this signature in database
GPG key ID: A2791F7C6D6C0186
2 changed files with 36 additions and 28 deletions

View file

@ -836,18 +836,16 @@ module Vmpooler
$logger.log('s', "[!] [#{pool_name}] is empty")
end
if total < pool_size
(1..(pool_size - total)).each do |_i|
if $redis.get('vmpooler__tasks__clone').to_i < $config[:config]['task_limit'].to_i
begin
$redis.incr('vmpooler__tasks__clone')
pool_check_response[:cloned_vms] += 1
clone_vm(pool_name, provider)
rescue => err
$logger.log('s', "[!] [#{pool_name}] clone failed during check_pool with an error: #{err}")
$redis.decr('vmpooler__tasks__clone')
raise
end
(pool_size - total).times do
if $redis.get('vmpooler__tasks__clone').to_i < $config[:config]['task_limit'].to_i
begin
$redis.incr('vmpooler__tasks__clone')
pool_check_response[:cloned_vms] += 1
clone_vm(pool_name, provider)
rescue => err
$logger.log('s', "[!] [#{pool_name}] clone failed during check_pool with an error: #{err}")
$redis.decr('vmpooler__tasks__clone')
raise
end
end
end