fix rubocop and spec tests

spec/dnsservice_helper.rb

@@ -0,0 +1,9 @@
+MockDNS = Struct.new(
+  # https://rubydoc.info/gems/google-cloud-dns/0.35.1/Google/Cloud/Dns
+  :change, :credentials, :project, :record, :zone,
+  keyword_init: true
+) do
+  def zone(zone)
+    self.zone = zone
+  end
+end

spec/spec_helper.rb

@@ -1,15 +1,18 @@
 # frozen_string_literal: true
 
 require 'simplecov'
+=begin
 SimpleCov.start do
   add_filter '/spec/'
 end
+=end
 require 'helpers'
 require 'rspec'
 require 'vmpooler'
 require 'redis'
 require 'vmpooler/metrics'
 require 'computeservice_helper'
+require 'dnsservice_helper'
 
 def project_root_dir
   File.dirname(File.dirname(__FILE__))

spec/unit/providers/gce_spec.rb

@@ -26,8 +26,6 @@ describe 'Vmpooler::PoolManager::Provider::Gce' do
     zone: '#{zone}'
     network_name: global/networks/default
     # network_name: 'projects/itsysopsnetworking/global/networks/shared1'
-    dns_zone_resource_name: 'example-com'
-    dns_zone: 'example.com'
 :pools:
   - name: '#{poolname}'
     alias: [ 'mockpool' ]
@@ -56,6 +54,8 @@ EOT
 
   subject { Vmpooler::PoolManager::Provider::Gce.new(config, logger, metrics, redis_connection_pool, 'gce', provider_options) }
 
+  before(:each) { allow(subject).to receive(:dns).and_return(MockDNS.new()) }
+
   describe '#name' do
     it 'should be gce' do
       expect(subject.name).to eq('gce')
@@ -89,7 +89,7 @@ EOT
     end
 
     context 'in itsysops' do
-      let(:vmname) { "instance-10" }
+      let(:vmname) { "instance-15" }
       let(:project) { 'vmpooler-test' }
       let(:config) { YAML.load(<<-EOT
 ---