From 36e9044087108cec87aabb5903a6f183d081a9d4 Mon Sep 17 00:00:00 2001 From: Jake Spain Date: Fri, 17 Feb 2023 09:01:53 -0500 Subject: [PATCH] Refactor obtaining and saving ip address --- lib/vmpooler/providers/gce.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/vmpooler/providers/gce.rb b/lib/vmpooler/providers/gce.rb index fd68287..6134be8 100644 --- a/lib/vmpooler/providers/gce.rb +++ b/lib/vmpooler/providers/gce.rb @@ -206,14 +206,14 @@ module Vmpooler result = connection.insert_instance(project, zone(pool_name), client) wait_for_operation(project, pool_name, result) created_instance = get_vm(pool_name, new_vmname) - # Exceptions thrown if ip does not exist in preexisting vm? Redis::CommandError: ERR wrong number of arguments for 'hset' command - @redis.with_metrics do |redis| - ip = created_instance['ip'] - redis.hset("vmpooler__vm__#{new_vmname}", 'ip', ip) - end created_instance end + def get_vm_ip_address(vm_name, pool_name) + vm_object = get_vm(pool_name, vm_name) + return vm_object['ip'] + end + # create_disk creates an additional disk for an existing VM. It will name the new # disk #{vm_name}-disk#{number_disk} where number_disk is the next logical disk number # starting with 1 when adding an additional disk to a VM with only the boot disk: