diff --git a/lib/vmpooler/cloud_dns.rb b/lib/vmpooler/cloud_dns.rb index ba56b2c..aececce 100644 --- a/lib/vmpooler/cloud_dns.rb +++ b/lib/vmpooler/cloud_dns.rb @@ -5,9 +5,10 @@ require 'google/cloud/dns' module Vmpooler class PoolManager + # This class interacts with GCP Cloud DNS to create or delete records. class CloudDns def initialize(project, dns_zone_resource_name) - @dns ||= Google::Cloud::Dns.new(project_id: project) + @dns = Google::Cloud::Dns.new(project_id: project) @dns_zone_resource_name = dns_zone_resource_name end diff --git a/spec/unit/providers/gce_spec.rb b/spec/unit/providers/gce_spec.rb index c893397..c4b8f25 100644 --- a/spec/unit/providers/gce_spec.rb +++ b/spec/unit/providers/gce_spec.rb @@ -267,6 +267,7 @@ EOT result = MockResult.new result.status = 'DONE' allow(connection).to receive(:insert_instance).and_return(result) + allow(subject).to receive(:dns_setup).and_return(true) end it 'should return a hash' do @@ -313,6 +314,7 @@ EOT result.status = 'DONE' allow(subject).to receive(:wait_for_operation).and_return(result) allow(connection).to receive(:delete_instance).and_return(result) + allow(subject).to receive(:dns_teardown).and_return(true) end it 'should return true' do @@ -584,6 +586,7 @@ EOT before(:each) do allow(subject).to receive(:connect_to_gce).and_return(connection) + allow(subject).to receive(:dns_teardown).and_return(true) end context 'with empty allowlist' do