puppetlabs/vmpooler-provider-gce
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler-provider-gce.git synced 2026-01-26 03:18:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added a check for failed create attempts, they are now retried up to 30 times

Browse source
This commit is contained in:
Samuel Beaulieu 2022-07-27 12:24:45 -05:00
parent b94d54f129
commit 26327210a4
No known key found for this signature in database
GPG key ID: 12030F74136D0F34
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/vmpooler/cloud_dns.rb
View file

@ -16,6 +16,7 @@ module Vmpooler
dns_zone = @dns.zone(@dns_zone_resource_name) if @dns_zone_resource_name dns_zone = @dns.zone(@dns_zone_resource_name) if @dns_zone_resource_name
return unless dns_zone && created_instance && created_instance['name'] && created_instance['ip'] return unless dns_zone && created_instance && created_instance['name'] && created_instance['ip']
retries = 0
name = created_instance['name'] name = created_instance['name']
begin begin
change = dns_zone.add(name, 'A', 60, [created_instance['ip']]) change = dns_zone.add(name, 'A', 60, [created_instance['ip']])
@ -25,6 +26,12 @@ module Vmpooler
# the error is Google::Cloud::AlreadyExistsError: alreadyExists: The resource 'entity.change.additions[0]' named 'instance-8.test.vmpooler.net. (A)' already exists # the error is Google::Cloud::AlreadyExistsError: alreadyExists: The resource 'entity.change.additions[0]' named 'instance-8.test.vmpooler.net. (A)' already exists
change = dns_zone.replace(name, 'A', 60, [created_instance['ip']]) change = dns_zone.replace(name, 'A', 60, [created_instance['ip']])
debug_logger("#{change.id} - #{change.started_at} - #{change.status} DNS address previously existed and was replaced") if change debug_logger("#{change.id} - #{change.started_at} - #{change.status} DNS address previously existed and was replaced") if change
rescue Google::Cloud::FailedPreconditionError => e
# this error was experienced intermittently, will retry to see if it can complete successfully
# the error is Google::Cloud::FailedPreconditionError: conditionNotMet: Precondition not met for 'entity.change.deletions[0]'
debug_logger("DNS create failed, retrying error: #{e}")
sleep 5
retry if (retries += 1) < 30
end end
end end