puppetlabs/vmpooler-provider-gce
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler-provider-gce.git synced 2026-01-26 11:28:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

code review fixes

Browse source
This commit is contained in:
Samuel Beaulieu 2021-12-29 12:17:25 -06:00
parent a4c730df7b
commit 0beec3d8e9
No known key found for this signature in database
GPG key ID: 12030F74136D0F34
4 changed files with 6 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

30
spec/unit/providers/gce_spec.rb
View file

@ -11,8 +11,7 @@ describe 'Vmpooler::PoolManager::Provider::Gce' do
let(:metrics) { Vmpooler::Metrics::DummyStatsd.new }
let(:poolname) { 'debian-9' }
let(:provider_options) { { 'param' => 'value' } }
# let(:project) { 'vmpooler-test' }
let(:project) { 'dio-samuel-dev' }
let(:project) { 'vmpooler-test' }
let(:zone) { 'us-west1-b' }
let(:config) { YAML.load(<<-EOT
---
@ -25,7 +24,6 @@ describe 'Vmpooler::PoolManager::Provider::Gce' do
project: '#{project}'
zone: '#{zone}'
network_name: global/networks/default
# network_name: 'projects/itsysopsnetworking/global/networks/shared1'
:pools:
- name: '#{poolname}'
alias: [ 'mockpool' ]
@ -34,7 +32,6 @@ describe 'Vmpooler::PoolManager::Provider::Gce' do
timeout: 10
ready_ttl: 1440
provider: 'gce'
# subnetwork_name: 'projects/itsysopsnetworking/regions/us-west1/subnetworks/vmpooler-test'
machine_type: 'zones/#{zone}/machineTypes/e2-micro'
EOT
)
@ -63,31 +60,6 @@ EOT
end
describe '#manual tests live' do
skip 'runs in gce' do
puts 'creating'
result = subject.create_vm(poolname, vmname)
subject.get_vm(poolname, vmname)
subject.vms_in_pool(poolname)
puts 'create snapshot w/ one disk'
result = subject.create_snapshot(poolname, vmname, 'sams')
puts 'create disk'
result = subject.create_disk(poolname, vmname, 10)
puts 'create snapshot w/ 2 disks'
result = subject.create_snapshot(poolname, vmname, 'sams2')
puts 'revert snapshot'
result = subject.revert_snapshot(poolname, vmname, 'sams')
result = subject.destroy_vm(poolname, vmname)
end
skip 'runs existing' do
# result = subject.create_snapshot(poolname, vmname, "sams")
# result = subject.revert_snapshot(poolname, vmname, "sams")
# puts subject.get_vm(poolname, vmname)
result = subject.create_vm(poolname, vmname)
result = subject.destroy_vm(poolname, vmname)
end
context 'in itsysops' do
let(:vmname) { "instance-15" }
let(:project) { 'vmpooler-test' }