puppetlabs/vmpooler-provider-gce
2
0
Fork 0
mirror of https://github.com/puppetlabs/vmpooler-provider-gce.git synced 2026-01-26 03:18:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

code review fixes

Browse source
This commit is contained in:
Samuel Beaulieu 2021-12-29 12:17:25 -06:00
parent a4c730df7b
commit 0beec3d8e9
No known key found for this signature in database
GPG key ID: 12030F74136D0F34
4 changed files with 6 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/vmpooler/providers/gce.rb
View file

@ -198,7 +198,7 @@ module Vmpooler
network_interfaces: [network_interfaces],
labels: { 'vm' => new_vmname, 'pool' => pool_name, project => nil }
)
# TODO: Maybe this will be needed to set the hostname (usually internal DNS name but in opur case for some reason its nil)
# TODO: Maybe this will be needed to set the hostname (usually internal DNS name but in our case for some reason its nil)
# given_hostname = "#{new_vmname}.#{dns_zone}"
# client.hostname = given_hostname if given_hostname