Fix rubocop issues

.rubocop.yml

@@ -18,6 +18,8 @@ Layout/HashAlignment:
     EnforcedHashRocketStyle: table
 Layout/FirstHashElementIndentation:
     EnforcedStyle: consistent
+Metrics/ParameterLists:
+    Enabled: False
 
 Style/StderrPuts:
   Enabled: false

lib/vmfloaty.rb

@@ -17,7 +17,7 @@ require 'vmfloaty/ssh'
 class Vmfloaty
   include Commander::Methods
 
-  def run
+  def run # rubocop:disable Metrics/AbcSize
     program :version, Vmfloaty::VERSION
     program :description, 'A CLI helper tool for Puppet Labs VM poolers to help you stay afloat'
 

lib/vmfloaty/abs.rb

@@ -82,10 +82,10 @@ class ABS
 
     jobs_to_delete = []
 
-    retStatus = {}
+    ret_status = {}
     hosts.each do |host|
-      retStatus[host] = {
+      ret_status[host] = {
-        'ok' => false
+        'ok' => false,
       }
     end
 
@@ -95,11 +95,11 @@ class ABS
       req_hash['allocated_resources'].each do |vm_name, _i|
         if hosts.include? vm_name['hostname']
           if all_job_resources_accounted_for(req_hash['allocated_resources'], hosts)
-            retStatus[vm_name['hostname']] = {
+            ret_status[vm_name['hostname']] = {
-              'ok' => true
+              'ok' => true,
             }
             jobs_to_delete.push(req_hash)
-        else
+          else
             puts "When using ABS you must delete all vms that you requested at the same time: Can't delete #{req_hash['request']['job']['id']}: #{hosts} does not include all of #{req_hash['allocated_resources']}"
           end
         end
@@ -118,7 +118,7 @@ class ABS
 
       return_result = conn.post 'return', req_obj.to_json
       req_obj['hosts'].each do |host|
-        response_body[host["hostname"]] = { 'ok' => true } if return_result.body == "OK"
+        response_body[host['hostname']] = { 'ok' => true } if return_result.body == 'OK'
       end
     end
 
@@ -187,16 +187,16 @@ class ABS
       },
     }
 
-    if options["priority"]
+    if options['priority']
-      if options["priority"] == "high"
+      req_obj[:priority] = if options['priority'] == 'high'
-        req_obj[:priority] = 1
+                             1
-      elsif options["priority"] == "medium"
+                           elsif options['priority'] == 'medium'
-        req_obj[:priority] = 2
+                             2
-      elsif options["priority"] == "low"
+                           elsif options['priority'] == 'low'
-        req_obj[:priority] = 3
+                             3
-      else
+                           else
-        req_obj[:priority] = options["priority"].to_i
+                             options['priority'].to_i
-      end
+                           end
     end
 
     puts "Posting to ABS #{req_obj.to_json}" if verbose
@@ -214,12 +214,11 @@ class ABS
       queue_place, res_body = check_queue(conn, saved_job_id, req_obj)
       return translated(res_body) if res_body
 
+      sleep_seconds = 10 if i >= 10
+      sleep_seconds = i if i < 10
+      puts "Waiting #{sleep_seconds} seconds to check if ABS request has been filled.  Queue Position: #{queue_place}... (x#{i})"
 
-      sleepSeconds = 10 if i >= 10
+      sleep(sleep_seconds)
-      sleepSeconds = i if i < 10
-      puts "Waiting #{sleepSeconds} seconds to check if ABS request has been filled.  Queue Position: #{queue_place}... (x#{i})"
-
-      sleep(sleepSeconds)
     end
     nil
   end
@@ -264,7 +263,7 @@ class ABS
 
     res = conn.get 'status'
 
-    return res.body == "OK"
+    res.body == 'OK'
   end
 
   def self.summary(verbose, url)

lib/vmfloaty/utils.rb

@@ -156,8 +156,8 @@ class Utils
         end
       end
     when 'ABS'
-      puts "ABS Not OK".red unless status_response
+      puts 'ABS Not OK'.red unless status_response
-      puts "ABS is OK".green if status_response
+      puts 'ABS is OK'.green if status_response
     else
       raise "Invalid service type #{service.type}"
     end